Repository navigation
enh(ci): fixes after #389 review - #412
Merged
Merged
Conversation
…ith the delivered sc) don't build/test everything when only the "stream-connectors-ci" workflow is updated (it's only a dispatcher)
…(it was ok before)
sdepassio
force-pushed
the
CTOR-2525-fix-ci-updates
branch
from
October 7, 2026 09:34
635ffea to
73b37f5
Compare
sdepassio
marked this pull request as ready for review
October 7, 2026 09:34
sdepassio
requested review from
kduret and
pkriko
and removed request for
a team
October 7, 2026 09:35
pkriko
previously approved these changes
Oct 8, 2026
tuntoja
reviewed
Oct 8, 2026
tuntoja
left a comment
tuntoja
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the follow-up. The orchestrator split, the single ci-status check and delivering the lib only after the connectors are tested against it all look good to me.
Three points, two with a suggestion you can apply directly:
- The lib is not delivered when only its version changes. After merge, unstable would get connectors requiring lib
>= 3.9.0while the lib there stays 3.8.1. - Dependency fixes of the connectors set in
stream-connectors.ymlare no longer delivered. - The connectors are delivered before the lib they depend on. On a release branch, testing can end up with connectors that cannot be installed.
Note for #409 / #410 (MON-205723), which will be rebased on this: the release tag trigger will move to stream-connectors-ci.yml, and .version.stream-connectors-lib will replace the version literal in point 1.
Co-authored-by: tuntoja <58987095+tuntoja@users.noreply.github.com>
tuntoja
previously approved these changes
Oct 12, 2026
tuntoja
left a comment
tuntoja
left a comment
Contributor
There was a problem hiding this comment.
Thanks, the three points are addressed:
- Lib version bump:
stream-connectors-lib.ymlis inlib_code, so a version bump delivers the lib. - Connector dependencies:
stream-connectors.ymlis back in thepackagingfilter. - Delivery order: the connectors are delivered by
stream-connectors-delivery.yml, only after the lib delivery succeeded or was skipped. I checked that the cache keys match the package job, and that every delivered connector is built in the run.
Nit, not blocking: version: "3.9.0" # previous version:"3.8.2" should say 3.8.1, since 3.8.2 was never released.
tuntoja
approved these changes
Oct 12, 2026
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes for CI after #389 review.
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist
Community contributors & Centreon team